Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how detailed we want the line items to be, so I just included everything I saw or remembered a discussion for. I probably missed some.
For what it's worth, I still think
xattreeis a horrible hack, and way too magical to rely on. It's fine for the MVP I guess. I've got some ideas how to improve on the general idea of marryingattrsandxarray. I added an item for this to phase 2.The timeline is optimistic. Pessimistic version, maybe MVP August, MMP end of year, and we play the final rollout by ear?