fix(io): extending and testing ascii writes #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
approved these changes
Oct 9, 2025
flopy4/mf6/converter.py
Outdated
| if comp is not None | ||
| ] | ||
| elif isinstance(field_value, (list, tuple)): | ||
| elif isinstance(field_value, (list, tuple, xattree.DataTreeList)): |
Member
There was a problem hiding this comment.
This could be
elif isinstance(field_value, collections.abc.Iterable):as DataTreeList satisfies that. The condition above already uses the fact DataTreeDict implements MutableMapping, I guess? And that could just be Mapping, too, I think
Contributor
Author
There was a problem hiding this comment.
thanks, I'll update that
| {% macro scalar(name, value) %} | ||
| {% set format = value|field_format %} | ||
| {% if value is not none %}{{ name.upper() }}{% if format != 'keyword' %} {{ value }}{% endif %}{% endif %} | ||
| {% if value is not none %}{{ inset ~ name.upper() }}{% if format != 'keyword' %} {{ value }}{% endif %}{% endif %} |
Member
There was a problem hiding this comment.
didn't know about the tilde for string concatenation before. TIL.
wpbonelli
reviewed
Oct 10, 2025
| else: | ||
| if field_value is not None: | ||
| blocks[block_name][field_name] = field_value | ||
| if isinstance(field_value, bool): |
Member
There was a problem hiding this comment.
this prevents false keywords from being written
mjreno
force-pushed
the
io_write_phase2
branch
from
614cc1b to
e9e4377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update writes to minimally support running a configuration.