Update SRS with more details #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll defer to @jdhughes-usgs @langevin-usgs @mjr-deltares on the requirements |
wpbonelli
approved these changes
Oct 8, 2024
christianlangevin
left a comment
christianlangevin
left a comment
There was a problem hiding this comment.
Seems like this is taking shape. A few minor comments included.
Co-authored-by: langevin-usgs <langevin@usgs.gov>
deltamarnix
force-pushed
the
srs-update
branch
from
56add47 to
aaf2266
Compare
christianlangevin
approved these changes
Nov 14, 2024
christianlangevin
left a comment
christianlangevin
left a comment
There was a problem hiding this comment.
Really nice @deltamarnix. I added a few suggestions. It's ready to go from my perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.