This introduces thread_auto_close and thread_auto_close_response.…
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Both these can be used to configure modmail to auto close a thread after some time has passed. `thread_auto_close_response` has a `%t` variable that can be used to insert human friendly time into the closing message.
fourjr
reviewed
Jun 23, 2019
|
|
||
| async def _grab_timeout( | ||
| self | ||
| ) -> typing.Union[None, isodate.duration.Duration, timedelta]: |
Collaborator
There was a problem hiding this comment.
do this instead in one line:
async def _grab_timeout(self) -> typing.Union[None, isodate.duration.Duration, timedelta]:Also, rename the function to _fetch_timeout 😛
Contributor
Author
There was a problem hiding this comment.
I was following PEP8. Are we using a different code style? 😅
Collaborator
There was a problem hiding this comment.
We follow our code style lul
whatever looks/works best i guess..
Collaborator
There was a problem hiding this comment.
Just use black for code formatting.
Contributor
Author
There was a problem hiding this comment.
@fourjr I committed that into one line, but the second black formatting commit reverted it back.
Collaborator
|
Can you also reflect the changes in the changelog? Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Both these can be used to configure modmail to auto close a thread after some time has passed.
thread_auto_close_responsehas a%tvariable that can be used to insert human friendly time into the closing message.This does not auto close threads that already exist and will have to be manually closed. But once the variable is configured, it will take it from there for every new thread.
Take a look at this P.R with two sets of eyes as this is my first attempt at calling methods that I did not write.
Resolves #161