Skip to content

Conversation

@alroniks
Copy link
Collaborator

What does it do?

It removes unused PHPUnit with the old version, also updates dependencies to fresh versions to be compatible with PHP 8.

It also fixes the link to Git.php class that should be in the proper case to discover over class-map.

Why is it needed?

To allow installation on ENVs with PHP 8 runtime.

Related issue(s)/PR(s)

N/A

How to test?

You can try to build a Docker image for MODX with Gitify on the board, that based on PHP 8 RC5 FPM official image.

FROM php:8.0-rc-fpm

MAINTAINER Ivan Klimchuk <ivan@klimchuk.com> (@alroniks)

RUN apt-get update && apt-get install -y curl zip zlib1g-dev unzip libzip-dev git vim libpng-dev libjpeg-dev libpq-dev libwebp-dev libfreetype6-dev libonig-dev && rm -rf /var/lib/apt/lists/*

RUN docker-php-ext-configure gd --with-jpeg --with-freetype --with-webp
RUN docker-php-ext-configure pdo_mysql --with-pdo-mysql=mysqlnd

RUN docker-php-ext-install pdo && \
    docker-php-ext-install pdo_mysql && \
    docker-php-ext-install gd && \
    docker-php-ext-install mbstring && \
    docker-php-ext-install opcache && \
    docker-php-ext-install zip && \
    docker-php-ext-install calendar

RUN php -r "readfile('http://getcomposer.org/installer');" | php -- --install-dir=/usr/bin/ --filename=composer

RUN cd /var/www && git clone -b fix/php8_compatibility https://github.com/modmore/gitify.git && cd gitify && composer update --no-dev && cd -

RUN { echo 'date.timezone=Europe/Minsk'; } > /usr/local/etc/php/conf.d/datetime.ini

WORKDIR /var/www/html/public

VOLUME /var/www/html/public

RUN usermod -u 1000 www-data

EXPOSE 9000

CMD ["php-fpm"]

@Mark-H
Copy link
Member

Mark-H commented Nov 20, 2020

Two changes in the composer.json and it's PHP8 compatible? :o

@alroniks
Copy link
Collaborator Author

@Mark-H I continue testing, but it fixes installation first. If other things work well, so... that's it. :)

@Mark-H
Copy link
Member

Mark-H commented Nov 20, 2020

Sweet. :D

@Mark-H Mark-H merged commit 896ec64 into master Dec 14, 2020
@Mark-H Mark-H deleted the fix/php8_compatibility branch October 10, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants