Skip to content

Conversation

@IMB11
Copy link
Member

@IMB11 IMB11 commented Oct 30, 2025

Runs download request and then gives browser blob, bypassing browser download flow preventing websocket blocking on firefox based browsers.

image

Backend doesn't return Content-Length header, but i've added support for it anyways incase it's added in the future.

@IMB11 IMB11 requested review from Prospector and fetchfern October 30, 2025 15:26
@IMB11 IMB11 added frontend Involves work from the frontend team servers Relates to the Modrinth Servers product labels Oct 30, 2025
@Prospector
Copy link
Member

Prospector commented Oct 30, 2025

hm, does it need both of those downloading indicators?

@IMB11
Copy link
Member Author

IMB11 commented Oct 30, 2025

@copilot Add a v-show on the ButtonStyled which contains the Downloading/Download text which is set to false when downloading.

Copy link

Copilot AI commented Oct 30, 2025

@IMB11 I've opened a new pull request, #4680, to work on those changes. Once the pull request is ready, I'll request review from you.

@Prospector Prospector added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit c74460f Oct 30, 2025
5 checks passed
Prospector added a commit that referenced this pull request Oct 31, 2025
Prospector added a commit that referenced this pull request Oct 31, 2025
Prospector added a commit that referenced this pull request Nov 2, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 2, 2025
Prospector added a commit that referenced this pull request Nov 7, 2025
@Prospector Prospector deleted the cal/dev-387 branch November 12, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Involves work from the frontend team servers Relates to the Modrinth Servers product

Development

Successfully merging this pull request may close these issues.

3 participants