-
Notifications
You must be signed in to change notification settings - Fork 351
fix: firefox backup download issues #4679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hm, does it need both of those downloading indicators? |
Member
Author
|
@copilot Add a v-show on the ButtonStyled which contains the Downloading/Download text which is set to false when downloading. |
Prospector
approved these changes
Oct 30, 2025
Prospector
approved these changes
Oct 30, 2025
Prospector
added a commit
that referenced
this pull request
Oct 31, 2025
This reverts commit c74460f.
Prospector
added a commit
that referenced
this pull request
Oct 31, 2025
Prospector
added a commit
that referenced
this pull request
Nov 2, 2025
Prospector
added a commit
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs download request and then gives browser blob, bypassing browser download flow preventing websocket blocking on firefox based browsers.
Backend doesn't return Content-Length header, but i've added support for it anyways incase it's added in the future.