Skip to content

Make major box shadows toggleable with Advanced rendering setting #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
Merged

Make major box shadows toggleable with Advanced rendering setting #4712

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4024e5a
Update App.vue
Airyzz Nov 1, 2025
20ffc61
Update App.vue
Airyzz Nov 4, 2025
3933a4a
Merge branch 'main' into fix-performance-fine
IMB11 Nov 7, 2025
8d8316b
Merge branch 'main' into fix-performance-fine
Prospector Nov 7, 2025
009041b
tone down light mode shadows, disable with advanced rendering disabled
Prospector Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions apps/app-frontend/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,11 @@ provideAppUpdateDownloadProgress(appUpdateDownload)
<template>
<SplashScreen v-if="!stateFailed" ref="splashScreen" data-tauri-drag-region />
<div id="teleports"></div>
<div v-if="stateInitialized" class="app-grid-layout experimental-styles-within relative">
<div
v-if="stateInitialized"
class="app-grid-layout experimental-styles-within relative"
:class="{ 'disable-advanced-rendering': !themeStore.advancedRendering }"
>
<Suspense>
<Transition name="toast">
<UpdateToast
Expand Down Expand Up @@ -914,7 +918,10 @@ provideAppUpdateDownloadProgress(appUpdateDownload)
<div
v-if="stateInitialized"
class="app-contents experimental-styles-within"
:class="{ 'sidebar-enabled': sidebarVisible }"
:class="{
'sidebar-enabled': sidebarVisible,
'disable-advanced-rendering': !themeStore.advancedRendering,
}"
>
<div class="app-viewport flex-grow router-view">
<transition name="popup-survey">
Expand Down Expand Up @@ -1194,9 +1201,19 @@ provideAppUpdateDownloadProgress(appUpdateDownload)
display: none;
}

.disable-advanced-rendering {
.app-sidebar::before {
box-shadow: none;
}

&.app-contents::before {
box-shadow: none;
}
}

.app-sidebar::before {
content: '';
box-shadow: -15px 0 15px -15px rgba(0, 0, 0, 0.2) inset;
box-shadow: -15px 0 15px -15px rgba(0, 0, 0, 0.1) inset;
top: 0;
bottom: 0;
left: -2rem;
Expand All @@ -1221,9 +1238,10 @@ provideAppUpdateDownloadProgress(appUpdateDownload)
right: calc(-1 * var(--left-bar-width));
bottom: calc(-1 * var(--left-bar-width));
border-radius: var(--radius-xl);
box-shadow:
1px 1px 15px rgba(0, 0, 0, 0.2) inset,
inset 1px 1px 1px rgba(255, 255, 255, 0.23);
box-shadow: 1px 1px 15px rgba(0, 0, 0, 0.1) inset;
border-color: var(--surface-5);
border-width: 1px;
border-style: solid;
pointer-events: none;
}

Expand Down