[stdlib] Save small move on Variant.__copyinit__ ( init_pointee_*).
#4136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, this PR removes a small move on `Variant.__copyinit__`, (`UnsafePointer.init_pointee_*`), It should also remove a move on `Optional`, `Dict._entries`, and `struct` using `Variant` 🎉 Signed-off-by: rd4com <144297616+rd4com@users.noreply.github.com>
lattner
approved these changes
Mar 30, 2025
Collaborator
lattner
left a comment
lattner
left a comment
There was a problem hiding this comment.
Very nice, thank you for the testcase improvements. @ConnorGray can you merge if you have no objections?
Contributor
Author
|
Thanks! theses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR removes a small move on
Variant.__copyinit__, (UnsafePointer.init_pointee_*),It should also remove a move on
Optional,Dict._entries,and
structusingVariant🎉