[stdlib] Add Error.as_string_slice() and polish
#4304
Conversation
| ), | ||
| ")", | ||
| ) | ||
| return String("Error(", repr(self.as_string_slice()), ")") |
There was a problem hiding this comment.
Is the repr necessary (can we make it "Error('" etc.)?
There was a problem hiding this comment.
I also don't like building a String unnecessarily, but I don't know whether to remove this. It adds " to the end and beginning of the message or ' if the message contains ", it also encodes control characters in the ASCII range. Since it encodes those characters instead of printing, I think it's worth it in cases where you would want to print something that might have been corrupted on the way. But I'm not sure.
There was a problem hiding this comment.
I see. Maybe we should make repr return a different Writable than String in the future.
There was a problem hiding this comment.
Maybe once we have some API for streaming a repr i.e. __repr__(self, mut writer: Writer)
martinvuyk
force-pushed
the
add-error-as-stringslice
branch
from
92a9cad to
b97aded
Compare
laszlokindrat
left a comment
laszlokindrat
left a comment
There was a problem hiding this comment.
Thanks! Could you please fix the conflicts so I can bring this in?
martinvuyk
force-pushed
the
add-error-as-stringslice
branch
from
b97aded to
263b19f
Compare
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
martinvuyk
force-pushed
the
add-error-as-stringslice
branch
from
263b19f to
e747213
Compare
|
@laszlokindrat done :) |
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in bc05a00! Thank you for your contribution 🎉 |
4 participants
Add
Error.as_string_slice()and polish