-
Notifications
You must be signed in to change notification settings - Fork 29
bump emberjson for 25.5 #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| requirements: | ||
| host: | ||
| - max =25.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: use mojo-compiler package now that it's released instead.
suggestion: add a requirements.build section that also specifies mojo-compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! What's the purpose of adding the requirements.build entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just completeness! https://pixi.sh/latest/reference/pixi_manifest/#host-dependencies
build - things that are executed at build time (compilers)
host - stuff that is linked against
run - stuff that you need around at runtime
We link against stuff supplied by the mojo-compiler package so technically we don't need to specify it as a build dep, but it makes the packages more robust to tooling changes by prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgreni is there a reason you picked the mojo pkg over mojo-compiler for the run and host? mojo bundles in the LSP, formatter, and debugger. https://forum.modular.com/t/mojo-now-available-in-conda-as-a-standalone-package/2052
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learning as I go here, but it seems like mojo test does not work correctly if just the mojo-compiler package is installed. So for tests specifying mojo is needed.
661a054 to
52d284d
Compare
Checklist
recipe.yamlfile specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.0(for new packages, or if the version changed).