Skip to content

Conversation

@bgreni
Copy link
Collaborator

@bgreni bgreni commented Aug 5, 2025

Checklist

  • My recipe.yaml file specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.
  • License file is packaged (see here for an example).
  • Set the build number to 0 (for new packages, or if the version changed).
  • Bumped the build number (if the version is unchanged).


requirements:
host:
- max =25.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: use mojo-compiler package now that it's released instead.
suggestion: add a requirements.build section that also specifies mojo-compiler.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! What's the purpose of adding the requirements.build entry?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just completeness! https://pixi.sh/latest/reference/pixi_manifest/#host-dependencies

build - things that are executed at build time (compilers)
host - stuff that is linked against
run - stuff that you need around at runtime

We link against stuff supplied by the mojo-compiler package so technically we don't need to specify it as a build dep, but it makes the packages more robust to tooling changes by prefix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgreni is there a reason you picked the mojo pkg over mojo-compiler for the run and host? mojo bundles in the LSP, formatter, and debugger. https://forum.modular.com/t/mojo-now-available-in-conda-as-a-standalone-package/2052

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learning as I go here, but it seems like mojo test does not work correctly if just the mojo-compiler package is installed. So for tests specifying mojo is needed.

@sstadick sstadick self-assigned this Aug 7, 2025
@bgreni bgreni force-pushed the emberjson-0.1.7 branch 2 times, most recently from 661a054 to 52d284d Compare August 7, 2025 18:45
@bgreni bgreni merged commit f86a263 into modular:main Aug 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants