Skip to content

Conversation

@thatstoasty
Copy link
Contributor

@thatstoasty thatstoasty commented Aug 20, 2025

Checklist

  • My recipe.yaml file specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.
  • License file is packaged (see here for an example).
  • Set the build number to 0 (for new packages, or if the version changed).
  • Bumped the build number (if the version is unchanged).

Copilot AI review requested due to automatic review settings August 20, 2025 00:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mist package recipe to be compatible with Mojo 25.5, including version bumps and build script adjustments.

  • Updates version from 25.4.0 to 25.5.0
  • Updates git revision to point to a newer commit
  • Adjusts the build script path from src/mist to mist

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

number: 0
script:
- mojo package src/mist -o ${{ PREFIX }}/lib/mojo/mist.mojopkg
- mojo package mist -o ${{ PREFIX }}/lib/mojo/mist.mojopkg
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build script path has changed from 'src/mist' to 'mist'. Please verify that the 'mist' directory exists at the root of the repository at the specified git revision, as this could cause build failures if the directory structure doesn't match.

Suggested change
- mojo package mist -o ${{ PREFIX }}/lib/mojo/mist.mojopkg
- mojo package src/mist -o ${{ PREFIX }}/lib/mojo/mist.mojopkg

Copilot uses AI. Check for mistakes.
@carolinefrasca carolinefrasca merged commit be24a87 into modular:main Aug 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants