Add support-path-mapping to mojo_library #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only changes here are making sure we let the args object handle path mapping. This is slightly complicated by using the dirname for import paths, but ignoring the value from our provider.
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Jul 22, 2025
Pulls in modular/rules_mojo#36 MODULAR_ORIG_COMMIT_REV_ID: 9d08bbab5524afd0d7e43d67a5033ed6b3a14920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only changes here are making sure we let the args object handle path
mapping. This is slightly complicated by using the dirname for import
paths, but ignoring the value from our provider.