-
-
Notifications
You must be signed in to change notification settings - Fork 367
Open
Description
Clear and concise description of the problem
I don't use react-router
Even if react-router-dom and react-router are marked as optional, these peerDeps are required for base @module-federation/bridge-react usage.
createRemoteAppComponent uses createLazyRemoteComponent, which uses withRouterData, which imports react-router-dom, so react-router-dom sneaks into js bundle
Also current implementation rewrites exportName and basename props, thus I'm not able to pass them (ironic, but I already provide my own basename prop)
Suggested solution
Provide analog for createLazyRemoteComponent and createRemoteAppComponent which wouldn't require react-router import
Example:
import { createRemoteAppComponent } from '@module-federation/bridge-react/base' // "react-router free", just render()Alternative
No response
Additional context
No response
Validations
- Read the Contributing Guidelines.
- Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
NGorteTC
Metadata
Metadata
Assignees
Labels
No labels