Skip to content

chore: fix nx building #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2023
Merged

chore: fix nx building #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abea599
chore: fix nx building
ScriptedAlchemy Jun 30, 2023
4861e0c
chore: fix nx building
ScriptedAlchemy Jun 30, 2023
a4eeb6e
chore: fix nx building
ScriptedAlchemy Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/3000-home/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
const { registerPluginTSTranspiler } = require('nx/src/utils/nx-plugin.js');

registerPluginTSTranspiler();
const { withNx } = require('@nrwl/next/plugins/with-nx');
const NextFederationPlugin = require('@module-federation/nextjs-mf');
const { createDelegatedModule } = require('@module-federation/utilities');
Expand Down
1 change: 1 addition & 0 deletions apps/3000-home/pages/dynamic-remote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
//eslint-disable-next-line
import { injectScript } from '@module-federation/utilities';
// example of dynamic remote import on server and client
const isServer = typeof window === 'undefined';
Expand Down
189 changes: 189 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions packages/nextjs-mf/src/plugins/NextFederationPlugin/next-fragments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export function applyRemoteDelegates(
compiler.options.module.rules.push({
enforce: 'pre',
test: [/_app/],
loader: path.resolve(__dirname, '../../loaders/patchDefaultSharedLoader'),
loader: require.resolve('../../loaders/patchDefaultSharedLoader'),
});
// Add the delegate loader for hoist and container to the module rules
compiler.options.module.rules.push({
Expand All @@ -86,7 +86,7 @@ export function applyRemoteDelegates(
//eslint-disable-next-line
/next[\/]dist/,
],
loader: path.resolve(__dirname, '../../loaders/delegateLoader'),
loader: require.resolve('../../loaders/delegateLoader'),
options: {
delegates,
},
Expand All @@ -102,14 +102,14 @@ export const applyPathFixes = (compiler, options) => {
if (options.enableImageLoaderFix && hasLoader(rule, 'next-image-loader')) {
// childCompiler.options.module.parser.javascript?.url = 'relative';
injectRuleLoader(rule, {
loader: path.resolve(__dirname, '../../loaders/fixImageLoader'),
loader: require.resolve('../../loaders/fixImageLoader'),
});
}

// url-loader fix for which adds remote's hostname to the assets url
if (options.enableUrlLoaderFix && hasLoader(rule, 'url-loader')) {
injectRuleLoader({
loader: path.resolve(__dirname, '../../loaders/fixUrlLoader'),
loader: require.resolve('../../loaders/fixUrlLoader'),
});
}
});
Expand Down
0 ...-mf/src/plugins/container/custom-jsonp.js → ...-mf/src/plugins/container/custom-jsonp.ts
View file
Open in desktop
File renamed without changes.
7 changes: 4 additions & 3 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,16 @@
"@module-federation/native-federation-typescript": [
"packages/native-federation-typescript/src/index.ts"
],
"@module-federation/nextjs-mf": ["packages/nextjs-mf/src"],
"@module-federation/nextjs-mf/utils": ["packages/nextjs-mf/utils"],
"@module-federation/nextjs-mf": ["packages/nextjs-mf/src/index.ts"],
"@module-federation/nextjs-mf/*": ["packages/nextjs-mf/*"],
"@module-federation/node": ["packages/node/src"],
"@module-federation/node/utils": ["packages/node/src/utils"],
"@module-federation/storybook-addon": [
"packages/storybook-addon/src/index.ts"
],
"@module-federation/typescript": ["packages/typescript/src/index.ts"],
"@module-federation/utilities": ["packages/utilities/src/index.ts"]
"@module-federation/utilities": ["packages/utilities/src/index.ts"],
"@module-federation/utilities/*": ["packages/utilities/*"]
}
},
"exclude": ["node_modules", "tmp"]
Expand Down