Skip to content

fix(dts-plugin): api type file should not related with manifest config #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

fix(dts-plugin): api type file should not related with manifest config #4230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fuzzy-lamps-confess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@module-federation/dts-plugin': patch
'@module-federation/manifest': patch
---

fix(dts-plugin): api type file should not related with manifest config
20 changes: 0 additions & 20 deletions packages/dts-plugin/src/core/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,14 @@ export const validateOptions = (options: HostOptions) => {
};

export function retrieveTypesAssetsInfo(options: RemoteOptions) {
const { moduleFederationConfig } = options;
let apiTypesPath = '';
let zipTypesPath = '';

let zipPrefix = '';

try {
const { tsConfig, remoteOptions, mapComponentsToExpose } =
retrieveRemoteConfig(options);
if (!Object.keys(mapComponentsToExpose).length || !tsConfig.files.length) {
return {
zipPrefix,
apiTypesPath,
zipTypesPath,
zipName: '',
Expand All @@ -58,22 +54,7 @@ export function retrieveTypesAssetsInfo(options: RemoteOptions) {
apiTypesPath = retrieveMfAPITypesPath(tsConfig, remoteOptions);
}

if (
typeof moduleFederationConfig.manifest === 'object' &&
moduleFederationConfig.manifest.filePath
) {
zipPrefix = moduleFederationConfig.manifest.filePath;
} else if (
typeof moduleFederationConfig.manifest === 'object' &&
moduleFederationConfig.manifest.fileName
) {
zipPrefix = path.dirname(moduleFederationConfig.manifest.fileName);
} else if (moduleFederationConfig.filename) {
zipPrefix = path.dirname(moduleFederationConfig.filename);
}

return {
zipPrefix,
apiTypesPath,
zipTypesPath,
zipName: path.basename(zipTypesPath),
Expand All @@ -82,7 +63,6 @@ export function retrieveTypesAssetsInfo(options: RemoteOptions) {
} catch (err) {
console.error(ansiColors.red(`Unable to compile federated types, ${err}`));
return {
zipPrefix,
apiTypesPath: '',
zipTypesPath: '',
zipName: '',
Expand Down
34 changes: 6 additions & 28 deletions packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,29 +162,15 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
logger.debug('start generating types...');
await generateTypesAPI({ dtsManagerOptions });
logger.debug('generate types success!');
const config = dtsManagerOptions.remote.moduleFederationConfig;
let zipPrefix = '';
if (typeof config.manifest === 'object' && config.manifest.filePath) {
zipPrefix = config.manifest.filePath;
} else if (
typeof config.manifest === 'object' &&
config.manifest.fileName
) {
zipPrefix = path.dirname(config.manifest.fileName);
} else if (config.filename) {
zipPrefix = path.dirname(config.filename);
}

if (isProd) {
const zipAssetName = path.join(zipPrefix, zipName);
const apiAssetName = path.join(zipPrefix, apiFileName);
if (
zipTypesPath &&
!compilation.getAsset(zipAssetName) &&
!compilation.getAsset(zipName) &&
fs.existsSync(zipTypesPath)
) {
compilation.emitAsset(
zipAssetName,
zipName,
new compiler.webpack.sources.RawSource(
fs.readFileSync(zipTypesPath),
false,
Expand All @@ -194,11 +180,11 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {

if (
apiTypesPath &&
!compilation.getAsset(apiAssetName) &&
!compilation.getAsset(apiFileName) &&
fs.existsSync(apiTypesPath)
) {
compilation.emitAsset(
apiAssetName,
apiFileName,
new compiler.webpack.sources.RawSource(
fs.readFileSync(apiTypesPath),
false,
Expand All @@ -212,11 +198,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
};
if (zipTypesPath && fs.existsSync(zipTypesPath)) {
const zipContent = fs.readFileSync(zipTypesPath);
const zipOutputPath = path.join(
compiler.outputPath,
zipPrefix,
zipName,
);
const zipOutputPath = path.join(compiler.outputPath, zipName);
await new Promise<void>((resolve, reject) => {
compiler.outputFileSystem.mkdir(
path.dirname(zipOutputPath),
Expand Down Expand Up @@ -248,11 +230,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {

if (apiTypesPath && fs.existsSync(apiTypesPath)) {
const apiContent = fs.readFileSync(apiTypesPath);
const apiOutputPath = path.join(
compiler.outputPath,
zipPrefix,
apiFileName,
);
const apiOutputPath = path.join(compiler.outputPath, apiFileName);
await new Promise<void>((resolve, reject) => {
compiler.outputFileSystem.mkdir(
path.dirname(apiOutputPath),
Expand Down
9 changes: 3 additions & 6 deletions packages/manifest/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,20 +259,17 @@ export function getTypesMetaInfo(
return defaultTypesMetaInfo;
}

const { apiFileName, zipName, zipPrefix } = retrieveTypesAssetsInfo({
const { apiFileName, zipName } = retrieveTypesAssetsInfo({
...normalizedRemote,
context,
moduleFederationConfig: pluginOptions,
});

const zip = path.join(zipPrefix, zipName);
const api = path.join(zipPrefix, apiFileName);

return {
path: '',
name: '',
zip,
api,
zip: zipName,
api: apiFileName,
};
} catch (err) {
logger.warn(
Expand Down