Skip to content

fix(rsbuild-plugin): create different temp filepath to prevent invalid manifest.exposes #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

fix(rsbuild-plugin): create different temp filepath to prevent invalid manifest.exposes #4233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-buttons-wonder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/rsbuild-plugin': patch
---

fix(rsbuild-plugin): create different temp filepath to prevent invalid manifest.exposes
16 changes: 7 additions & 9 deletions packages/rsbuild-plugin/src/utils/addDataFetchExposes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,11 @@ export function addDataFetchExposes(
return;
}

const tempDataFetchFilepath = path.resolve(
process.cwd(),
`node_modules/${TEMP_DIR}/data-fetch-fallback.ts`,
);
const tempDataFetch = path.resolve(process.cwd(), `node_modules/${TEMP_DIR}`);
const content = `export const fetchData=()=>{throw new Error('should not be called')};`;
fs.ensureDirSync(path.dirname(tempDataFetchFilepath));
fs.writeFileSync(tempDataFetchFilepath, content);
fs.ensureDirSync(tempDataFetch);

Object.keys(exposes).forEach((key) => {
Object.keys(exposes).forEach((key, index) => {
const expose = exposes[key];
if (typeof expose !== 'string') {
return;
Expand All @@ -63,6 +59,8 @@ export function addDataFetchExposes(
const dataFetchPath = `${absPath.replace(path.extname(absPath), '')}.${DATA_FETCH_IDENTIFIER}.ts`;

const dataFetchClientPath = `${absPath.replace(path.extname(absPath), '')}.${DATA_FETCH_IDENTIFIER}.client.ts`;
const tempFile = path.join(tempDataFetch, `data-fetch-fallback${index}.ts`);
fs.writeFileSync(tempFile, content);

const dateFetchClientKey = addDataFetchExpose(
exposes,
Expand All @@ -72,14 +70,14 @@ export function addDataFetchExposes(
);
if (!isServer && dateFetchClientKey) {
exposes[dateFetchClientKey.replace(DATA_FETCH_CLIENT_SUFFIX, '')] =
addExcludeDtsSuffix(tempDataFetchFilepath);
addExcludeDtsSuffix(tempFile);
return;
}

const dataFetchKey = addDataFetchExpose(exposes, key, dataFetchPath);
if (dataFetchKey && fs.existsSync(dataFetchClientPath)) {
exposes[`${dataFetchKey}${DATA_FETCH_CLIENT_SUFFIX}`] =
addExcludeDtsSuffix(tempDataFetchFilepath);
addExcludeDtsSuffix(tempFile);
}
});
}