Skip to content

Conversation

@jherr
Copy link
Contributor

@jherr jherr commented Jun 11, 2020

Removing the requirement on metadata and updating the docs to have even more content.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2020

🦋 Changeset is good to go

Latest commit: ef37f25

We got this.

This PR includes changesets to release 2 packages
Name Type
@module-federation/dashboard Patch
@module-federation/dashboard-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

const convertToGraph = require("../convertToGraph");

describe("should convert Plugin data to graph", () => {
// I think this test is running against outdated data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably figure this one out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need to update the copy of the data.

@jherr jherr merged commit 50aa8b1 into master Jun 11, 2020
@jherr jherr deleted the fix/remove-metadata-requirement branch June 11, 2020 02:15
github-actions bot pushed a commit that referenced this pull request Jun 25, 2020
* Bunch of small fixes for the plugin

* Unbumping versions

* Fixing tests

* Adding a changeset
ScriptedAlchemy pushed a commit that referenced this pull request Apr 16, 2021
* Bunch of small fixes for the plugin

* Unbumping versions

* Fixing tests

* Adding a changeset
ScriptedAlchemy pushed a commit that referenced this pull request Apr 17, 2021
* Bunch of small fixes for the plugin

* Unbumping versions

* Fixing tests

* Adding a changeset
ScriptedAlchemy pushed a commit that referenced this pull request Apr 17, 2021
* Bunch of small fixes for the plugin

* Unbumping versions

* Fixing tests

* Adding a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants