update: nextjs-ssr sample #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PeaceDate is attempting to deploy a commit to the Module Federation Team on Vercel. A member of the Team first needs to authorize it. |
PeaceDate
force-pushed
the
e2e-nextjs-srr-uncomment-after-fix
branch
from
a3e0cfa to
e15f821
Compare
PeaceDate
force-pushed
the
e2e-nextjs-srr-uncomment-after-fix
branch
from
e15f821 to
e56aaac
Compare
edchai
suggested changes
Feb 6, 2023
nextjs-ssr/e2e/checkApps.cy.ts
Outdated
| // let host = property.host === 3001 ? appsData[0].host : property.host === 3002 ? appsData[1].host : appsData[2].host; | ||
| const appName = property.host === 3001 ? appsData[0].appName : appsData[1].appName; | ||
| const host = property.host === 3001 ? appsData[0].host : appsData[1].host; | ||
| let appName = property.host === 3001 ? appsData[0].appName : property.host === 3002 ? appsData[1].appName : appsData[2].appName; |
Contributor
There was a problem hiding this comment.
do not like the idea of ternar inside ternar , it is unreadable. Pls find another way
Contributor
Author
There was a problem hiding this comment.
No need at all. Fixed
PeaceDate
force-pushed
the
e2e-nextjs-srr-uncomment-after-fix
branch
from
e56aaac to
d749212
Compare
edchai
approved these changes
Feb 6, 2023
PeaceDate
force-pushed
the
e2e-nextjs-srr-uncomment-after-fix
branch
from
d749212 to
b2404c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncomment lines of code after Hydration error is fixed in this PR #2729