Skip to content

Use base64 encoding for Protobuf Handler #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Use base64 encoding for Protobuf Handler #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions router-protobuf/src/main/kotlin/io/moia/router/proto/ProtoEnabledRequestHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package io.moia.router.proto

import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyRequestEvent
import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyResponseEvent
import com.google.common.net.MediaType
import io.moia.router.JsonDeserializationHandler
import io.moia.router.JsonSerializationHandler
import io.moia.router.RequestHandler
import io.moia.router.ResponseEntity

abstract class ProtoEnabledRequestHandler : RequestHandler() {

Expand All @@ -11,4 +15,12 @@ abstract class ProtoEnabledRequestHandler : RequestHandler() {

override fun deserializationHandlers() =
listOf(ProtoDeserializationHandler(), JsonDeserializationHandler(objectMapper))

override fun <T> createResponse(
contentType: MediaType?,
input: APIGatewayProxyRequestEvent,
response: ResponseEntity<T>
): APIGatewayProxyResponseEvent {
return super.createResponse(contentType, input, response).withIsBase64Encoded(true)
}
}
4 changes: 3 additions & 1 deletion router-protobuf/src/test/kotlin/io/moia/router/proto/RequestHandlerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package io.moia.router.proto

import assertk.assert
import assertk.assertions.isEqualTo
import assertk.assertions.isTrue
import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyRequestEvent
import io.moia.router.Request
import io.moia.router.ResponseEntity
Expand Down Expand Up @@ -66,6 +67,7 @@ class RequestHandlerTest {

assert(response.statusCode).isEqualTo(200)
assert(Sample.parseFrom(response.bodyAsBytes())).isEqualTo(request)
assert(response.isBase64Encoded).isTrue()
}

@Test
Expand All @@ -83,7 +85,7 @@ class RequestHandlerTest {
}

@Test
fun `should return api error in prots`() {
fun `should return api error in protos`() {

val response = testRequestHandler.handleRequest(
GET("/some-error")
Expand Down