Skip to content

set default for EDIT_ON_DOUBLECLICK to False #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

set default for EDIT_ON_DOUBLECLICK to False #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/moin/cli/migration/moin19/import19.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Copyright: 2008 MoinMoin:JohannesBerg
# Copyright: 2008-2011 MoinMoin:ThomasWaldmann
# Copyright: 2023-2024 MoinMoin:UlrichB
# Copyright: 2023-2025 MoinMoin:UlrichB
# License: GNU GPL v2 (or any later version), see LICENSE.txt for details.

"""
Expand Down Expand Up @@ -948,7 +948,7 @@ def _process_usermeta(self, metadata):
# stuff we want to have stored as boolean:
bool_defaults = [ # taken from cfg.checkbox_defaults
(SHOW_COMMENTS, "False"),
(EDIT_ON_DOUBLECLICK, "True"),
(EDIT_ON_DOUBLECLICK, "False"),
(SCROLL_PAGE_AFTER_EDIT, "True"),
(WANT_TRIVIAL, "False"),
(MAILTO_AUTHOR, "False"),
Expand Down
4 changes: 2 additions & 2 deletions src/moin/config/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Copyright: 2010 MoinMoin:DiogenesAugusto
# Copyright: 2011 MoinMoin:AkashSinha
# Copyright: 2023 MoinMoin project
# Copyright: 2024 MoinMoin:UlrichB
# Copyright: 2024-2025 MoinMoin:UlrichB
# License: GNU GPL v2 (or any later version), see LICENSE.txt for details.

"""
Expand Down Expand Up @@ -576,7 +576,7 @@ def __init__(self, exprstr):
CSS_URL: None,
ISO_8601: False,
MAILTO_AUTHOR: False,
EDIT_ON_DOUBLECLICK: True,
EDIT_ON_DOUBLECLICK: False,
SCROLL_PAGE_AFTER_EDIT: True,
SHOW_COMMENTS: False,
WANT_TRIVIAL: False,
Expand Down