Theme consolidation regarding template show.html #1941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Changes look OK, but with window width less than 930 pixels the navigation bar is hidden and replaced with a "toggle menu" hamburger in upper right. Clicking it has no effect. |
Collaborator
Author
|
I am getting this "toggle menu" as well with theme focus and window width less than 930 pixels. Clicking the button opens the navigation area as expected. Looks like problems with Javascript in your environment. Can you check the same with branch master? It should have the same behavior. |
Collaborator
Author
|
I will close this PR because of conflicts and create a new one for removal of show.html from theme 'focus'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a redundant template, but adds an additional call to theme() for themes other than 'focus'.
I would be happy to receive your feedback.