Config: add a dict-like getter #1964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes the access to optional configuration options much easier
sebix
added a commit
to sebix/moin
that referenced
this pull request
Jul 25, 2025
Introduces a new optional configuration parameter to specify any instance-specific extensions for the markdown parser based on moinwiki#1964 implements moinwiki#1957
Comment on lines
+269
to
+277
| def get(self, item, default=None): | ||
| """Dict-like get method. | ||
| Return the value for key if key is in the dictionary, else default. | ||
| If default is not given, it defaults to None, so that this method never raises a KeyError.""" | ||
| try: | ||
| return getattr(self, item) | ||
| except AttributeError: | ||
| return default | ||
|
|
Member
There was a problem hiding this comment.
IIRC the idea of the DefaultConfig is that it has defaults for all supported attributes, so one would never get this AttributeError.
Having it in this class is also useful because it is one place where settings and their default can be looked up.
sebix
added a commit
to sebix/moin
that referenced
this pull request
Jul 25, 2025
Introduces a new optional configuration parameter to specify any instance-specific extensions for the markdown parser based on moinwiki#1964 implements moinwiki#1957
sebix
added a commit
to sebix/moin
that referenced
this pull request
Jul 26, 2025
Introduces a new optional configuration parameter to specify any instance-specific extensions for the markdown parser based on moinwiki#1964 implements moinwiki#1957
sebix
added a commit
to sebix/moin
that referenced
this pull request
Jul 28, 2025
Introduces a new optional configuration parameter to specify any instance-specific extensions for the markdown parser based on moinwiki#1964 implements moinwiki#1957
sebix
added a commit
to sebix/moin
that referenced
this pull request
Jul 28, 2025
Introduces a new optional configuration parameter to specify any instance-specific extensions for the markdown parser based on moinwiki#1964 implements moinwiki#1957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the access to optional configuration options much easier