Skip to content

Conversation

@ThomasWaldmann
Copy link
Member

No description provided.

@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Aug 29, 2025

I had some PyCharm Junie AI credits left this month, so I used them to do global typos and grammar fixing. Although the changes were done automatically, it was quite some work to convince the AI to keep going and do that for ALL code files and not just one or a few.

I did not review the changes; maybe someone else can help with that. Guess that just pushing manual fix commits to my branch is much more effective than giving comments here on GitHub.

I had to adjust Bandit excludes a bit, because it complained about some code I did not touch and that also maybe isn't worth Bandit-checking.

@ThomasWaldmann ThomasWaldmann marked this pull request as ready for review August 29, 2025 21:01
@ThomasWaldmann ThomasWaldmann changed the title fix typos and grammar code: fix typos and grammar Aug 29, 2025
@RogerHaase
Copy link
Member

Tested with a fresh clone on Windows 10. When starting the built-in server the first time there is a syntax warning:

\frontend\views.py:426: SyntaxWarning: invalid escape sequence '\ '

which is odd as line 426 is in the middle of a comment. Stopping the server and restarting makes the warning disappear. Had the same issue with a months old clone of the TW repo which is why I tried again with a fresh clone. No other problems noted during light testing that included creating a new item.

(moin-venv-python) C:\Clones\ThomasWaldmann\moin>git checkout typos-grammar
Switched to a new branch 'typos-grammar'
branch 'typos-grammar' set up to track 'origin/typos-grammar'.

(moin-venv-python) C:\Clones\ThomasWaldmann\moin>moin run
2025-08-31 14:00:02,465 WARNING moin.log:119 C:\Clones\ThomasWaldmann\moin-venv-python\Lib\site-packages\passlib\pwd.py:16: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
2025-08-31 14:00:03,132 WARNING moin.log:119 C:\Clones\ThomasWaldmann\moin\src\moin\apps\frontend\views.py:426: SyntaxWarning: invalid escape sequence '\ '
 * Debug mode: off
2025-08-31 14:00:04,201 INFO werkzeug:97 ←[31m←[1mWARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.←[0m
 * Running on http://127.0.0.1:5000
2025-08-31 14:00:04,201 INFO werkzeug:97 ←[33mPress CTRL+C to quit←[0m

(moin-venv-python) C:\Clones\ThomasWaldmann\moin>moin run
2025-08-31 14:00:38,783 WARNING moin.log:119 C:\Clones\ThomasWaldmann\moin-venv-python\Lib\site-packages\passlib\pwd.py:16: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
 * Debug mode: off
2025-08-31 14:00:39,637 INFO werkzeug:97 ←[31m←[1mWARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.←[0m
 * Running on http://127.0.0.1:5000
2025-08-31 14:00:39,637 INFO werkzeug:97 ←[33mPress CTRL+C to quit←[0m

(moin-venv-python) C:\Clones\ThomasWaldmann\moin>

@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Sep 1, 2025

@RogerHaase That SyntaxWarning was an issue that existed already before this PR, but I fixed it nevertheless.

This PR is based on 59fc2cb of 2025-08-25, which was current master when I started with it.

@RogerHaase RogerHaase merged commit 849f90b into moinwiki:master Sep 1, 2025
14 of 15 checks passed
@ThomasWaldmann ThomasWaldmann deleted the typos-grammar branch September 1, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants