Skip to content

remove inline styles from index.html and forms.html #1816 #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

remove inline styles from index.html and forms.html #1816 #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/moin/static/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,11 @@ span.db-inlinemediaobject span.db-caption { display: none; } /* inline captions
.moin-index tr th { text-align: center; }
.moin-clr { clear: both; }
.moin-index-menu { margin-bottom: 1em; }
.moin-index-menu > p > i { margin-bottom: 1em; color: red; }
.moin-index-menu li { display: inline-block; }
.moin-select-allitem { display: inline-block; cursor: default; text-align: left; }
.moin-download-link { display: none; }
.moin-contenttype-selection { margin: .5em 0; }
.moin-contenttype-selection { margin: .5em 0; display: none; }
.moin-contenttype-selection div { cursor: pointer; margin: 0 0 .5em 0; padding: .5em 1.2em .5em .5em; height: 1em; text-align: center; }

.moin-contenttype-selection form { z-index: 2; background: var(--bg-primary);
Expand All @@ -518,15 +519,15 @@ span.db-inlinemediaobject span.db-caption { display: none; } /* inline captions
width: 99%; margin-left: .5%; margin-bottom: 1.5em; display: none; }

.moin-namespace-selection { background: var(--bg-primary); border-radius: 7px;
border: 3px solid var(--border); padding: .2em; }
border: 3px solid var(--border); padding: .2em; display: none; }
.moin-namespace-selection ul li { list-style-type: none; font-size: 1.25em; }
.moin-newitem-toggle,
.moin-ns-toggle,
.moin-ct-toggle { color: var(--primary); }
#moin-newitem { width: 50%; }
.moin-new-item { margin-left: 1em; }
.moin-newitem-selection { background: var(--bg-primary); border-radius: 7px;
border: 3px solid var(--border); padding: .2em; }
border: 3px solid var(--border); padding: .2em; display: none; }
#moin-initials { width: 90%; margin: 1em auto 1em auto; text-align: center; }
#moin-initials a { display: inline-block; margin: 2px 1px; padding: 4px 5px; }
#moin-initials a.selected { background: var(--bg-inverse); border-radius: 5px;
Expand Down Expand Up @@ -557,7 +558,7 @@ li.moin-selected-groups { font-size: 1em; font-weight: bold; }
.jfu-file { background: linear-gradient(to right, var(--jfu-progress) 50%, transparent 50%); background-size: 200% 100%;
background-position: right bottom; transition:all 1s ease; padding: 1em; }
.jfu-file.jfu-failed { background: linear-gradient(to right, var(--jfu-failed) 100%, transparent 100%); }
.jfu-bar { margin-top: 1em; font-weight: bold; background: var(--jfu-progress); }
.jfu-bar { margin-top: 1em; font-weight: bold; background: var(--jfu-progress); width: 0%; }
#jfu-fileupload { margin-left: 1em; }

/* Forms - User Settings, rename, delete, destroy, register, diff... */
Expand Down
2 changes: 1 addition & 1 deletion src/moin/templates/forms.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<div id="jfu-file_upload">
<input id="jfu-fileupload" type="file" name="file_storage" data-url={{ submit_url }} multiple>
<div id="jfu-progress">
<p class="jfu-bar" style="width: 0%;"></p>
<p class="jfu-bar"></p>
</div>
</div>
{%- endmacro %}
Expand Down
10 changes: 5 additions & 5 deletions src/moin/templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ <h1>{{ title }}</h1>
<div class="moin-index-menu">
{% if not (dirs or files) %}
<p>
<i class="fa fa-minus-circle fa-lg" style="color: red;"></i>
<i class="fa fa-minus-circle fa-lg"></i>
{{ _("There are no items or read permission is denied for all.") }}
</p>
{% else %}
Expand Down Expand Up @@ -155,8 +155,8 @@ <h1>{{ title }}</h1>
</div>
{% endif %}

{# Hidden namespace selection content that is revealed if user clicks namespace button above. #}
<div class="moin-namespace-selection" style="display: none;">
{# Hidden namespace selection content that is revealed by javascript if user clicks namespace button above. #}
<div class="moin-namespace-selection">
<p> {{ _("Click home icon to view namespace home page or click name to view namespace index.") }} </p>
<ul class="moin-namespaces">
<li><i class="fa fa-home"></i> <a href="{{ url_for('frontend.index', item_name='all') }}">{{ _("all") }}</a></li>
Expand All @@ -171,7 +171,7 @@ <h1>{{ title }}</h1>
</div>

{# Hidden filter content that is revealed if user clicks filter button above. #}
<div class="moin-contenttype-selection" style="display: none;">
<div class="moin-contenttype-selection">
{% set unknown_items_label = _("items having unknown mime types") %}
{{ gen.form.open(form, method="get", action=url_for('frontend.index', item_name=item_name)) }}
<a href="#" class="moin-filter-toggle moin-button">
Expand All @@ -186,7 +186,7 @@ <h1>{{ title }}</h1>
</div>

{# Hidden New Item content that is revealed if user clicks New Item button above. #}
<div class="moin-newitem-selection" style="display: none;">
<div class="moin-newitem-selection">
<br/>
<form class="moin-new-item" action={{ url_for('.ajaxmodify') }} method="post">
<label for="moin-newitem">{{ _("Item name") }}</label>
Expand Down
Loading