Some Itemtype related code changes

[roland-ruedenauer]

Userprofile items: set properties ITEMTYPE and REV_NUMBER at creation.
Use existing itemtype constants in blog.py.

[UlrichB22]

Existing users still do not have ITEMTYPE and REV_NUMBER in there meta data. What is the background for this change?

[roland-ruedenauer]

The motivation here is improving consistency in the foundations of the data model.

• Why set ITEMTYPE for most of the entries but not Userprofile?
• Searching for meta[REV_NUMBER] indicates pieces of existing code expect the property to exist

Especially the REV_NUMBER looks confusing to me. Sometimes it is missing for an item, while for newer revisions it might me present. Then it is unclear whether it is 0 based or not.

[UlrichB22]

Should we change the 'moin maint-validate-metadata' command to set ITEMTYPE and REV_NUMBER for existing wikis?

moin/src/moin/cli/maint/modify_item.py

Lines 289 to 292 in 464244c

	# Skipping checks for userprofiles, as revision numbers and parentids are not used here
	if backend == app.cfg.backend_mapping[NAMESPACE_USERPROFILES]:
	continue
	# fix bad parentid references and repeated or missing revision numbers

[roland-ruedenauer]

Should we change the 'moin maint-validate-metadata' command to set ITEMTYPE and REV_NUMBER for existing wikis?

In my opinion: yes, for sure

You may also check the content import functionality from old wiki instances does "the right thing" too.