Rst converter: fix internal cross-references. #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, internal links to sections fail for the rST converter. Add test cases for what needs to be fixed. The expected results were determined/tested with a test document in a wiki instance.
The "refid" attribute works fine with explicit targets. IDs of section headings are generated by Moin using a different normalization function. Find the matching section element and create a refid "a la Moin".
Contributor
Author
|
Links fixed by this PR: .. _section:1:
Internal Links
--------------
Implicit targets
''''''''''''''''
Section titles become implicit targets. Referencing them ignores
case: `explicit targets`_ as well as `Explicit targets`_.
An `anonymous reference, redirected to the first section`__.
__ `Internal Links`_
A reference to the Greek τίτλος_.
A link to the section with `two
spaces`_.
τίτλος
^^^^^^
Non-ASCII section title (using the Greek alphabet).
Two spaces
^^^^^^^^^^^
The title of this section has two spaces in the rST source.
Explicit targets
''''''''''''''''
First_, a reference to the `first paragraph`_.
A link to the explicit target representing section:1_.Still missing (requires change to the handling of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next set of fixes for #1680