Skip to content

fix ordering issue when both node and bun are selected #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix ordering issue when both node and bun are selected #1537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ async function graph({
const selectedNodeJsVersionsSet = new Set(selectedNodeJsVersions);
const selectedBunVersionsSet = new Set(selectedBunVersions);

const runtimesOrder = {
NODE: 0,
BUN: 1,
};

const valuesNodejs = benchmarkResultsNodejs
.filter(
b =>
Expand All @@ -190,6 +195,7 @@ async function graph({
// artificical benchmark name to make sure its always sorted by
// benchmark and node-version
benchmark: [
runtimesOrder.NODE,
BENCHMARKS_ORDER[b.benchmark],
NODE_VERSIONS.indexOf(getNodeMajorVersionNumber(b.runtimeVersion)),
b.runtimeVersion,
Expand All @@ -209,6 +215,7 @@ async function graph({
// artificical benchmark name to make sure its always sorted by
// benchmark and node-version
benchmark: [
runtimesOrder.BUN,
BENCHMARKS_ORDER[b.benchmark],
BUN_VERSIONS.indexOf(getBunMajorVersionNumber(b.runtimeVersion)),
b.runtimeVersion,
Expand Down
Loading