feat: Add Paseri to benchmarks #1540
Conversation
vbudovski
force-pushed
the
feature/paseri2
branch
4 times, most recently
from
4145154 to
dd39245
Compare
|
@moltar I’ll sort out the merge conflicts in a bit, but are there any issues with this new approach? |
vbudovski
force-pushed
the
feature/paseri2
branch
2 times, most recently
from
31c01df to
5fe1c38
Compare
| "docs:watch": "tsc --project tsconfig.docs.json --watch --preserveWatchOutput & serve docs", | ||
| "docs:build": "tsc --project tsconfig.docs.json", | ||
| "compile:deepkit": "deepkit-type-install && rimraf cases/deepkit/build && tsc -p cases/deepkit/tsconfig.json", | ||
| "compile:paseri": "rimraf cases/paseri/build && esbuild cases/paseri/src/index.ts --bundle --minify --platform=node --outdir=cases/paseri/build && tsc --emitDeclarationOnly cases/paseri/src/index.ts --outDir cases/paseri/build", |
There was a problem hiding this comment.
Why is the esbuild buildstep necessary? is it because paseri targets deno and won't run on node without compiling?
There was a problem hiding this comment.
Nothing to do with Deno. Paseri is ESM-only, while this library is CJS. You can’t mix import types, so we need to recompile it to CJS to match.
There was a problem hiding this comment.
Ah yeah of course. Another maintenance task incoming: switch to ESM 😁
There was a problem hiding this comment.
See my previous PR where I did just that 😂
| }, | ||
| "include": ["**/*.ts"] | ||
| "include": ["**/*.ts"], | ||
| "exclude": ["cases/paseri/src/*.ts"] |
There was a problem hiding this comment.
Things getting complicated here @moltar.
Would be nice to have some kind of isolation for all the libraries 😁. I have the feeling that sooner or later we'll have some problems due to having all those libraries in a single npm project.
Never heard of jsr.io before but it looks good to me 👍. Let me know if you need help with resolving the conflict 😄. |
vbudovski
force-pushed
the
feature/paseri2
branch
from
5fe1c38 to
ef11f52
Compare
|
@DarkGL Could I get your review also please? |
|
@vbudovski will do it tomorrow |
vbudovski
force-pushed
the
feature/paseri2
branch
from
21c3df1 to
4f76e03
Compare
4 participants
This adds the Paseri parsing library to the benchmark.