feat: Initial checkin that allows basic setup #1
Conversation
cprice404
left a comment
cprice404
left a comment
There was a problem hiding this comment.
LGTM just one quick question
| @@ -0,0 +1,3 @@ | |||
| python3 -m venv client_sdk_python_env | |||
There was a problem hiding this comment.
Is this file for devs, or for github workflows?
There was a problem hiding this comment.
This is for dev setup. I will rename this file and put local in the script name to make that clear. Thank you :)
There was a problem hiding this comment.
cool - FWIW I think we should be steering devs towards using pyenv (or similar) for managing python installations. Using virtualenv here is a Very Good Thing, but I would still warn people against doing a system-install of python3 via brew, and prefer pyenv. I think this script will still work fine as-is but it might be worth adding a comment at the top of it to recommend pyenv :)
just a pet peeve of mine as I have spent so many hours helping people debug issues with system-wide installs of python (and ruby and gradle and node and...) over the years :)
There was a problem hiding this comment.
Renamed prepare_local_env.sh -> prepare_local_dev_env.sh
No description provided.