fix: Return explicit message for OK Responses with incorrect state #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given GRPC OK Responses aren't logged (rightfully so). There are still bugs that can be encountered if the response content is incorrect.
e.g. SetResponse should only have ECacheResult.OK and GetResponse should only support ECacheResult.Hit or ECacheResult.Miss.
Any other ECacheResult is indicative of a bug in MomentoSdk or on SCS. Throwing an exception with generic message will hide the underlying issue. Hence, setting an explicitmessage for such exceptions so any reports can be easily worked on immediately instead of having to tell customers to enable debug logging in the SDK. Enabling debug logging on customer's environments will take time and also same logging related challeneges would apply.