-
Notifications
You must be signed in to change notification settings - Fork 7
test: Add basic integration test and ci setup #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a super basic happy path integration test using the `unittest` library.
Runs on every push and on pull requests.
|
@gautamomento Might want to chat with you about organization of the workflows in this repo - I'm not 100% sure if we need the |
Yea sure thing lets chat about this. |
gautamomento
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. But would like to better understand new ci.yml vs modifying existing. So, lets sync up on that.
Accidentally clicked approve, wanted to comment instead.
Yeah, to summarize my thoughts - the existing workflows are I think its more logical to group by type of thing the workflow is doing, similar to how the java sdk has ci.yml and cd.yml - so a workflow for running tests and a workflow for building and pushing the package. |
Aha thank you. Like this. |
|
@gautamomento my thinking was add |
That sounds reasonable. Please add an issue here so we don't miss it. |
Added #19 |
Part of #3.
This adds a super basic happy path integration test using the
unittestpackage. A newCIGitHub Action runs the tests on every pull request and on pushes tomain.