ci: Reorganize workflows #20
Conversation
Group workflows by action that needs to happen (run tests, build and release package), rather than by what event is the trigger. This allows for something like running tests to happen on both pushes to main and on pull requests. This removes the pull_request.yml file, since it should no longer be needed, and renames push_request.yml to cd.yml.
| python -m pip install --upgrade pip | ||
| pip install setuptools wheel build | ||
|
|
||
| - name: Build package |
There was a problem hiding this comment.
I don't think this is needed, since we're already building the package in both of the other workflows?
client-sdk-python/.github/workflows/ci.yml
Lines 29 to 30 in 8d17319
and
But it's possible I'm missing something?
There was a problem hiding this comment.
Are you saying that we don't need to build the code in ci.yaml and cd.yaml, or in this pr_request.yml?
There was a problem hiding this comment.
Ah sorry that wasn't clear - AFAICT all pull_request.yml was doing was building the package, and ci.yml and cd.yml already both do that, so I think it's ok to delete this file.
There was a problem hiding this comment.
👍 I agree if we have ci.yml we def don't need pull_request.yml
Closes #19
Group workflows by action that needs to happen (run tests, build and release package), rather than by what event is the trigger. This allows for something like running tests to happen on both pushes to main and on pull requests.
This removes the
pull_request.ymlfile, since it should no longer be needed, and renamespush_request.ymltocd.yml.