Skip to content

chore: update list of retryable gRPC functions #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

chore: update list of retryable gRPC functions #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 42 additions & 22 deletions src/momento/retry/default_eligibility_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from .eligibility_strategy import EligibilityStrategy
from .retryable_props import RetryableProps

RETRYABLE_STATUS_CODES: list[grpc.StatusCode] = [
RETRYABLE_STATUS_CODES: set[grpc.StatusCode] = {
# # including all the status codes for reference, but
# # commenting out the ones we don't want to retry on for now.
# grpc.StatusCode.OK,
Expand All @@ -25,41 +25,61 @@
grpc.StatusCode.UNAVAILABLE, # type: ignore[misc]
# grpc.StatusCode.DATA_LOSS,
# grpc.StatusCode.UNAUTHENTICATED,
]
}

RETRYABLE_REQUEST_TYPES: list[str] = [
"/cache_client.Scs/Set",
RETRYABLE_REQUEST_TYPES: set[str] = {
"/cache_client.Scs/Get",
"/cache_client.Scs/GetBatch",
"/cache_client.Scs/Set",
"/cache_client.Scs/SetBatch",
# Not retryable: "/cache_client.Scs/SetIf",
# SetIfNotExists is deprecated
# Not retryable: "/cache_client.Scs/SetIfNotExists",
"/cache_client.Scs/Delete",
# not idempotent: "/cache_client.Scs/Increment"
"/cache_client.Scs/DictionarySet",
# not idempotent: "/cache_client.Scs/DictionaryIncrement",
"/cache_client.Scs/KeysExist",
# Not retryable: "/cache_client.Scs/Increment",
# Not retryable: "/cache_client.Scs/UpdateTtl",
"/cache_client.Scs/ItemGetTtl",
"/cache_client.Scs/ItemGetType",
"/cache_client.Scs/DictionaryGet",
"/cache_client.Scs/DictionaryFetch",
"/cache_client.Scs/DictionarySet",
# Not retryable: "/cache_client.Scs/DictionaryIncrement",
"/cache_client.Scs/DictionaryDelete",
"/cache_client.Scs/DictionaryLength",
"/cache_client.Scs/SetFetch",
"/cache_client.Scs/SetSample",
"/cache_client.Scs/SetUnion",
"/cache_client.Scs/SetDifference",
"/cache_client.Scs/SetFetch",
# not idempotent: "/cache_client.Scs/SetIfNotExists"
# not idempotent: "/cache_client.Scs/ListPushFront",
# not idempotent: "/cache_client.Scs/ListPushBack",
# not idempotent: "/cache_client.Scs/ListPopFront",
# not idempotent: "/cache_client.Scs/ListPopBack",
"/cache_client.Scs/ListFetch",
# Warning: in the future, this may not be idempotent
# Currently it supports removing all occurrences of a value.
# In the future, we may also add "the first/last N occurrences of a value".
# In the latter case it is not idempotent.
"/cache_client.Scs/SetContains",
"/cache_client.Scs/SetLength",
# Not retryable: "/cache_client.Scs/SetPop",
# Not retryable: "/cache_client.Scs/ListPushFront",
# Not retryable: "/cache_client.Scs/ListPushBack",
# Not retryable: "/cache_client.Scs/ListPopFront",
# Not retryable: "/cache_client.Scs/ListPopBack",
# Not used: "/cache_client.Scs/ListErase",
"/cache_client.Scs/ListRemove",
"/cache_client.Scs/ListFetch",
"/cache_client.Scs/ListLength",
# not idempotent: "/cache_client.Scs/ListConcatenateFront",
# not idempotent: "/cache_client.Scs/ListConcatenateBack"
]
# Not retryable: "/cache_client.Scs/ListConcatenateFront",
# Not retryable: "/cache_client.Scs/ListConcatenateBack",
# Not retryable: "/cache_client.Scs/ListRetain",
"/cache_client.Scs/SortedSetPut",
"/cache_client.Scs/SortedSetFetch",
"/cache_client.Scs/SortedSetGetScore",
"/cache_client.Scs/SortedSetRemove",
# Not retryable: "/cache_client.Scs/SortedSetIncrement",
"/cache_client.Scs/SortedSetGetRank",
"/cache_client.Scs/SortedSetLength",
"/cache_client.Scs/SortedSetLengthByScore",
"/cache_client.pubsub.Pubsub/Subscribe",
}


class DefaultEligibilityStrategy(EligibilityStrategy):
def is_eligible_for_retry(self, props: RetryableProps) -> bool:
"""Determines whether a grpc call is able to be retried.
"""Determines whether a grpc call can be retried.

The determination is based on the result of the last invocation of the call and whether the call is idempotent.

Expand Down
Loading