Skip to content

fix: Push always uses default version #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2021
Merged

fix: Push always uses default version #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db315f9
fix: Push always uses default version
gautamomento Nov 4, 2021
96a440c
fix if statement
gautamomento Nov 4, 2021
78015a0
fix build script
gautamomento Nov 4, 2021
43cd1bb
fix formatting
gautamomento Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ jobs:
run: |
set -e
set -x
export PYPI_MOMENTO_WIRE_TYPE_VERSION=0.0.devBuild
export MOMENTO_SDK_VERSION=0.0.devBuild
python -m build
shell: bash
5 changes: 2 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import setuptools
import os
import time

version = os.getenv("MOMENTO_SDK_VERSION")

if [version == None]:
version = '0.0.dev'
if(version is None):
version = '0.0.localdev0'

# version is the only dynamic configuration
setuptools.setup(
Expand Down