obsolete children of 'upper digestive tract disorder' (MONDO:0044991) #6654
Conversation
src/ontology/mondo-edit.obo
Outdated
| is_a: MONDO:0020019 ! digestive tract malformation | ||
| is_a: MONDO:0021147 ! disorder of development or morphogenesis | ||
| relationship: disease_has_location UBERON:0001043 ! esophagus | ||
| relationship: has_characteristic MONDO:0021136 ! rare |
There was a problem hiding this comment.
@nicolevasilevsky did you add this manually?
There was a problem hiding this comment.
or maybe that is the re-wiring?
There was a problem hiding this comment.
this was rewiring, I didn't add any of these
src/ontology/mondo-edit.obo
Outdated
| is_a: MONDO:0015207 {source="Orphanet:91358"} ! non-syndromic esophageal malformation | ||
| is_a: MONDO:0020019 ! digestive tract malformation | ||
| is_a: MONDO:0021147 ! disorder of development or morphogenesis | ||
| relationship: disease_has_location UBERON:0001043 ! esophagus |
There was a problem hiding this comment.
did you add this manually?
There was a problem hiding this comment.
these were added in the rewiring (hence they don't have a source) and I think I missed these (otherwise I would have added a source). We should double check these - if they should be kept or deleted (I'll do it after you are done with your review, I don't want to make changes and then this diff + comments will get all wonky)
src/ontology/mondo-edit.obo
Outdated
| is_a: MONDO:0015930 {source="Orphanet:2004"} ! respiratory malformation | ||
| is_a: MONDO:0003749 {source="https://orcid.org/0000-0001-5208-3432"} ! esophageal disorder | ||
| is_a: MONDO:0015504 {source="Orphanet:2004", source="https://orcid.org/0000-0001-5208-3432"} ! larynx anomaly | ||
| relationship: has_characteristic MONDO:0021136 ! rare |
There was a problem hiding this comment.
did you add this manually?
There was a problem hiding this comment.
yes, the green I either added (line 317187) or added my ORCID (in line 317188) and line 317189 came from rewiring and I left it. I figured those will be addressed (and sources added) later?
the red were added due to rewiring and i removed them (with the exception of line 317213, larynx anomaly, which I added my ORCID to, because I agreed with it.
|
@sabrinatoro can this be merged? Or do you have other comments or things that should be addressed? |
There was a problem hiding this comment.
@nicolevasilevsky there are 2 terms which I think might need additional parents.
src/ontology/mondo-edit.obo
Outdated
| is_a: MONDO:0015160 {source="Orphanet:2538"} ! multiple congenital anomalies/dysmorphic syndrome-variable intellectual disability syndrome | ||
| is_a: MONDO:0015210 {source="Orphanet:2538"} ! syndromic gastroduodenal malformation |
There was a problem hiding this comment.
should this term stay in the "digestive tract malformation" branch? (MONDO:0020019)
It is a syndrome with "small stomach (microgastria) "
There was a problem hiding this comment.
we haven't necessarily been classifying syndromes as children of all the features. If we made this a child of 'digestive tract malformation', then it should also be a child of something that would include 'limb reduction defect' too. I've been classifying terms like this as hereditary diseases and/syndromic diseases for the most part. (And there are some that are classified under these other Orphanet grouping terms, like here. We should probably revisit this grouping class and the related ones later.
|
If this looks okay to you @sabrinatoro, please merge when the QC passes |
close #6650