Skip to content

improve overall typing, add industry fields, migrate to server actions #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyranaus merged 25 commits into from
Jan 26, 2025
Merged

improve overall typing, add industry fields, migrate to server actions #19

kyranaus merged 25 commits into from
Jan 26, 2025

Conversation

@jason301c
Copy link
Contributor

@jason301c jason301c commented Jan 25, 2025

  • Implemented fetch-jobs.ts, and refactored it to be inside of lib instead of /api.
  • Use industry fields inside of filters instead of study fields
  • Ensure that the types match the types from the scraper

Test whether the API works:

  • setup MONGODB_URI on .env
  • run npm run dev, if URL is not localhost:3000, need to set CURRENT_URL on .env
  • go to the jobs page, the data should be the first entry of the MongoDB collection.

jason301c and others added 16 commits January 25, 2025 23:26
@jason301c
refactor: Rename industry to studyFields and update related types…
ebcdf4a 
… and logic
@jason301c
refactor: update JobFilters type and constants with stricter typing
d2f28e8
@jason301c
refactor: update job and filter types with new enums and interfaces
7ca5b8d
@jason301c
Merge remote-tracking branch 'origin/development' into frontend/jason…
d4ee9d4 
…/types
@jason301c
refactor: Move fetchJobs.ts from app/api to lib directory
f086509
@jason301c
refactor: Rename fetchJobs file to fetch-jobs for consistency
ddfc6b2
@jason301c
docs: Add API documentation for GET /api/jobs endpoint
cd30d75
@jason301c
feat: add pagination and dynamic filters to fetchJobs function
2f2857e
@jason301c
refactor: Update job and filter types with new fields and options
2f45d37
@jason301c
feat: Add total job count to API response and update fetchJobs interface
df18b07
@jason301c
refactor: Simplify job details component and improve error handling i…
2c77cda 
…n jobs page
@jason301c
refactor: Use environment variable for base URL in fetchJobs
b739256
@jason301c
fix: Add optional chaining to job details arrays to prevent runtime e…
455fb07 
…rrors
@jason301c
chore: run prettier
d41adcb
@jason301c
fix ESLint issues
ebb6c79
@jason301c
Merge branch 'development' into frontend/jason/types
288e025
@github-actions
Copy link

github-actions bot commented Jan 25, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-0dae88c00-19.eastasia.4.azurestaticapps.net

@edwnl edwnl changed the title improve overall typing, add industry fields, implement fetchJobs improve overall typing, add industry fields, migrate to server actions Jan 26, 2025
@github-actions
Copy link

github-actions bot commented Jan 26, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-0dae88c00-19.eastasia.4.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 26, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-0dae88c00-19.eastasia.4.azurestaticapps.net

@edwnl edwnl requested a review from kyranaus January 26, 2025 16:03
kyranaus
kyranaus reviewed Jan 26, 2025
View reviewed changes
@kyranaus kyranaus merged commit 9335a1b into development Jan 26, 2025
2 checks passed
@kyranaus kyranaus deleted the frontend/jason/types branch January 26, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edwnl edwnl edwnl left review comments

@kyranaus kyranaus kyranaus left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jason301c @edwnl @kyranaus