upgrade node #144
Merged
upgrade node #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mt-dfrey
commented
Oct 5, 2023
mt-dfrey
commented
- build(all) upgrade node from 12 -> 16
- build(all) upgrade node from 16 -> 18
mt-dfrey
commented
Oct 5, 2023
| "license": "MIT", | ||
| "scripts": { | ||
| "build": "rm -rf dist && webpack", | ||
| "build": "rm -rf dist && NODE_OPTIONS=--openssl-legacy-provider webpack", |
Contributor
Author
There was a problem hiding this comment.
see the commit message of 60fbf99 for an explanation of this option.
node 17 switched to openssl 3, which has some incompatibilities with older versions, see https://nodejs.org/en/blog/release/v17.0.0#openssl-3-0 webpack 4 relies on the older openssl version, only webpack 5 and newer uses openssl 3, see webpack/webpack#14532 (comment) webpack/webpack#14584 That's why we use the --openssl-legacy-provider node option when running webpack.
mt-ronkorving
approved these changes
Oct 5, 2023
mt-rorykelly
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.