Fix detecting linting failures in CircleCI #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command being run by Circle CI would not return an error code if the linting failed on the JS step, because it only looked at the exit code of linting the TS files.
mt-ronkorving
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The linting of Javascript files was including the auto-generated files under
docs/, which would cause it to fail, but the Circle CI job wasn't failing because thelintscript in package.json runs linting of JS and TS files, but only "looks" at the exit code of the last command.Changes
docs/folder to eslint ignore so the auto-generated and minified files do not cause linting errors.