Refactor improve typescript coverage #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt-micky
previously approved these changes
Dec 5, 2019
mt-roberto
force-pushed
the
refactor-improve-typescript-coverage
branch
3 times, most recently
from
2cc1846 to
7b1aa0d
Compare
mt-max
previously approved these changes
Dec 5, 2019
mt-roberto
force-pushed
the
refactor-improve-typescript-coverage
branch
2 times, most recently
from
9029725 to
81c8188
Compare
mt-roberto
force-pushed
the
refactor-improve-typescript-coverage
branch
2 times, most recently
from
035960c to
9e27c36
Compare
mt-micky
reviewed
Dec 9, 2019
Contributor
mt-micky
left a comment
mt-micky
left a comment
There was a problem hiding this comment.
Let's have a chat f2f to make sure we are taking the right path
mt-roberto
force-pushed
the
refactor-improve-typescript-coverage
branch
from
9e27c36 to
1c31ae5
Compare
mt-micky
reviewed
Dec 9, 2019
mt-micky
previously approved these changes
Dec 9, 2019
mt-roberto
force-pushed
the
refactor-improve-typescript-coverage
branch
from
1c31ae5 to
8f05c8a
Compare
mt-roberto
force-pushed
the
refactor-improve-typescript-coverage
branch
from
8f05c8a to
836778a
Compare
mt-max
approved these changes
Dec 9, 2019
mt-micky
approved these changes
Dec 9, 2019
Contributor
Author
|
@mt-micky Can I merge and bump up later? |
Contributor
|
Yes, let's merge. Then we will have to bump the version and release on GitHub and NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased typescript coverage
Catch errors
Bump up to version 1.2.4