-
Notifications
You must be signed in to change notification settings - Fork 0
Updating the documents with a few fixes. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c929669
Updaing the
aasawariMongoDB 141a7c1
Adding fixes after code review
aasawariMongoDB ae02dc5
Documenting to add pkgconf before installing mongodb driver
aasawariMongoDB 3c11f17
Modifyng the sentence after review
aasawariMongoDB f3f1f2e
Adding command to install openssl before pkgconf
aasawariMongoDB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we trust that
openssl@3will already be installed in Homebrew? Just asking as that's what we're expecting to find withpkg-config.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Homebrew includes an alias for
opensslthat points toopenssl@3, so unless people explicitly installopenssl@1they'll get the expected version.I am a bit curious about "expecting to find" here - we're looking for openssl >= 1.0.1 in CheckSSL.m4, so I'm not sure why we're expecting to find openssl 3.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. I just saw my local package and forgot that
CheckSSL.m4only requires 1.0.1+ when I wrote that.It was less about suggesting version 3+ and more about whether we should tell users they need
opensslitself installed (to avoid falling back to Secure Transport). I don't recall installing it manually in Homebrew. I think it was just pulled in by some other packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we may consider suggesting people install
opensslas well - even though there is a high likelihood that it will have been installed as a dependency for other development tools.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.