Skip to content

Conversation

@yuzhouliu9
Copy link

@yuzhouliu9 yuzhouliu9 commented Jul 13, 2022

Replacing relative import of tester with full path.

This fixes go mod tidy issues with go version 1.18+. This lib is imported by our other repositories.

The other changes are just formatting changes applied automatically by my IDE, I can revert if desired.

@yuzhouliu9 yuzhouliu9 requested a review from colinhoglund July 13, 2022 16:17
@yuzhouliu9 yuzhouliu9 marked this pull request as ready for review July 13, 2022 16:17
@richerve
Copy link

richerve commented Jul 14, 2022

LGTM

I don't think we would be contributing upstream as that seems abandonware at this stage so changes in formatting and importing are 👍🏼

@yuzhouliu9 yuzhouliu9 merged commit 9fc5f72 into master Jul 14, 2022
@yuzhouliu9 yuzhouliu9 deleted the bugfix_relative_import branch July 14, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants