chore: CHARTS-3889 Update all embedding urls #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andym03
changed the title
andym03
commented
May 1, 2020
| ) { | ||
| let token = jwt.sign({ username: loginDetails.username }, config.secret, { | ||
| expiresIn: "24h" // expires in 24 hours | ||
| expiresIn: "12h" // expires in 12 hours |
Contributor
Author
There was a problem hiding this comment.
Edit: This change is no longer necessary, but it doesn't hurt. I hadn't made my provider yet and was confused.
scottsidwell
approved these changes
May 1, 2020
…s apps instead of charts-dev. Updated Stitch sample to use production stitch app, no longer requiring an update to the base url
andym03
force-pushed
the
chore/CHARTS-3889-update-embedding-links
branch
from
2f8e18a to
c26abfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket link
📈 task: CHARTS-3889
Description
Updated all embedding URL's to refer to a production environment. This includes all Charts embedding base URL's and the Stitch base url in the Realm sample. Since we don't use the develop url for Realm, we no longer need to update the base URL so I removed that instruction from the Readme, along with the line of code it referred to.