-
Notifications
You must be signed in to change notification settings - Fork 236
INT-793 help window #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT-793 help window #216
Conversation
src/connect/index.jade
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shows how a help icon would be added, with the help id as a data-hook.
795d225
to
7c0eaa1
Compare
this isn't working yet.
7c0eaa1
to
2fbdec2
Compare
Is this waiting for review? |
Let's wait until I've merged your help window improvements in here, then probably needs a fresh rebase. |
# Conflicts: # package.json # src/electron/menu.js # src/electron/window-manager.js
rebase was getting too crazy, had to merge master to get this in sync again. |
|
Closing in favor of #288, which is a squashed, rebased version. |
The idea is to have a separate
./src/help
folder that exports a Help object. It is an Ampersand view for a new page, but it also exports aHelp.open
convenience method that takes an id (a string).All help items have a unique id, for example
auth-kerberos-principal
. An info help button is placed somewhere in the jade templates like soAn event listener listens to all
'click i.help'
events, extracts the data-hook as id, and callsHelp.open(id)
.Haven't figured out how to open the right window yet, and how to pass the id to the Help view.
@imlucas I'm sure this would only take you 15 minutes. Could you have a look? Could you also explain how electron window vs. page vs. router vs. app works? That's an area that's still not quite clear to me.