-
Notifications
You must be signed in to change notification settings - Fork 236
test(monorepo): Make sure all tests are green COMPASS-4704 #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
dd5ab22
test(@mongodb-js/triejs): Disable tests in package
gribnoysup 6309002
test(hadron-style-manager): Ignore metadata generated by tests
gribnoysup 50ab420
test(hadron-react-utils): Compile before running tests; Add base webp…
gribnoysup 324a621
test(hadron-react-components): Compile before running tests; Add base…
gribnoysup 7407de0
test(hadron-react-buttons): Compile before running tests; Add base we…
gribnoysup 9454bfc
test(hadron-react-bson): Compile before running tests; Add base webpa…
gribnoysup 32d8515
test(hadron-plugin-manager): Ease assertion to avoid failing on stack…
gribnoysup 228cb5b
test(hadron-compile-cache): Update babel hashes to match new ones; Re…
gribnoysup a8f4afc
test(hadron-build): Skip very flaky functional test on darwin
gribnoysup 23bffcb
chore(mongodb-connection-model): Remove directConnection logic from m…
gribnoysup 85091f9
fix(@mongodb-js/compass-aggregations): Make sure that react-dnd uses …
gribnoysup f581ddd
test(@mongodb-js/compass-connect): Update url to match driver behavior
gribnoysup 6a566f0
chore(@mongodb-js/compass-crud): Add missing peer dep for the driver
gribnoysup 7031bdf
test(@mongodb-js/compass-deployment-awareness): Ease assertion to onl…
gribnoysup a17c5b6
chore(@mongodb-js/compass-shell): Add missing mocha dep; Fix version …
gribnoysup 0d2dde2
fix(@mongodb-js/compass-query-bar): Update query-parser to latest; Fi…
gribnoysup f63bd71
test(@mongodb-js/compass-home): Remove real dependencies from home te…
gribnoysup 4a2e30b
test(@mongodb-js/electron-wix-msi): Fix Buffer reference when mocking…
gribnoysup 8a03264
ci(monorepo): Bootstrap all the packages; Remove compass scope
gribnoysup e9fb9d0
chore(mongodb-explain-compat, storage-mixin): Keep package-log in git…
gribnoysup 7fe9a84
fix(@mongodb-js/compass-import-export): Fix fast-csv import
gribnoysup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit surprising – the driver should not require this to be present unless we’re actually doing anything with FLE … are we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah, no, I don't think so... Let me double-check that I actually got the reason for this right in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so seems it's a breaking* change introduced in driver here https://github.com/mongodb/node-mongodb-native/pull/2760/files#diff-c088451b2b6c514ba0f163c7c00dfae50dc86c534feeffe18cf618749af66da0R15
* - breaking only for webpack because it tries to bundle mongodb-client-encryption and because this time it's a top level import it throws instead of warning as it does with v3.6.3