-
Notifications
You must be signed in to change notification settings - Fork 237
feat(compass-sidebar): Add loading states for collection in sidebar COMPASS-5211 #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9783bba
fix(collection-model): Do not exctract type as part of the collInfo
gribnoysup bf3e88a
misc(compass-components): Move ui colors out of components folder: Ad…
gribnoysup fb1185d
feat(compass-components): Add hooks for handling focus and hover stat…
gribnoysup fbffada
feat(compass-components): Add hooks that manage treeview navigation b…
gribnoysup 5ba0478
feat(compass-components): Add helper component to handle loading UI d…
gribnoysup feb0ae7
feat(compass-components): Add new databases navigation tree component…
gribnoysup 1c99d63
feat(compass-sidebar): Replace old navigation tree with the new one a…
gribnoysup 437f504
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup 15c9e88
chore(compass-components): Also provide content-visibility for collec…
gribnoysup 9bfcd9b
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup 91f4ee6
chore(compass-sidebar): Handle sidebar actions for collections / views
gribnoysup 758d5ea
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup 22c421e
chore(compass-components, compass-databases-navigation): Move sidebar…
gribnoysup 20d20e1
chore(e2e): Update sidebar selector
gribnoysup 52239a3
chore: Ignore testing-library/dom dependency at the root
gribnoysup daf9472
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup 9f4d84a
test(mongodb-compass): Update test for the new menu behavior
gribnoysup d68819b
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup d5f1cc3
chore(databases-navigation): Refactor the whole thing to use react-vi…
gribnoysup 4075a31
chore(databases-navigation): Reimplement most of the keyboard support…
gribnoysup 89a6bec
chore(databases-navigation): Add rest of the keyboard handlers; Simpl…
gribnoysup 423f1bc
chore(databases-navigation): Add back animations for the loading list
gribnoysup 87eea6a
chore(compass-sidebar): Fetch all collections when user starts to filter
gribnoysup d8fab7e
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup 7dcb94b
chore(databases-navigation): Fix tests
gribnoysup 24f268e
Merge branch 'compass-5211-async-sidebar' of github.com:mongodb-js/co…
gribnoysup 51d3865
chore(databases-navigation): Fix more tests
gribnoysup 7f13e1b
Merge remote-tracking branch 'origin/main' into compass-5211-async-si…
gribnoysup 5548eec
chore(instance-model, database-model, collection-model): Move optiona…
gribnoysup be820e0
fix(databases-collections): Fix missing initial state
gribnoysup ba0aafa
chore(compass-components): Remove log statement
gribnoysup e045661
fix(sidebar): Fix initial state test
gribnoysup a2405d7
chore(databases-navigation): Do not use process.env for test values
gribnoysup 3eeaddc
chore(collection): Move showCollectionsSubmenu to create/replaceTab m…
gribnoysup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
ignores: | ||
# TODO: See package.json. Remove when all packages using the same webpack version | ||
# TODO: See package.json. Remove when all packages use the same version | ||
- '@webpack-cli/serve' | ||
- '@testing-library/dom' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 1 addition & 8 deletions
9
configs/mocha-config-compass/register/jsdom-global-register.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,3 @@ | ||
if (typeof window === 'undefined') { | ||
require('jsdom-global/register'); | ||
|
||
window.requestAnimationFrame = function (callback) { | ||
return setTimeout(callback, 1); | ||
}; | ||
window.cancelAnimationFrame = function (id) { | ||
clearTimeout(id); | ||
}; | ||
require('global-jsdom')(undefined, { pretendToBeVisual: true }); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍