feat(connections): adds form validation errors utility COMPASS-5268 #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
requested changes
Dec 16, 2021
mcasimir
reviewed
Dec 16, 2021
addaleax
reviewed
Dec 21, 2021
| connectionString: ConnectionString | ||
| ): FormValidationError[] { | ||
| const errors: FormValidationError[] = []; | ||
| if (connectionString.searchParams.get('authMechanism') === 'MONGODB-X509') { |
There was a problem hiding this comment.
fyi, if #2651 is merged first it might be nice to update the core here to have similar changes :)
mabaasit
reviewed
Dec 22, 2021
leorossi
force-pushed
the
COMPASS-5268
branch
3 times, most recently
from
92d9896 to
8db50fb
Compare
mcasimir
force-pushed
the
COMPASS-5268
branch
from
8db50fb to
70c2646
Compare
Anemy
reviewed
Jan 12, 2022
There was a problem hiding this comment.
Looks like there are new package-lock.json files in the changes - I think we probably want to add git ignores for those like the one for packages? https://github.com/mongodb-js/compass/blob/main/.gitignore#L20
Not sure how they ended up in the diff
scripts/package-lock.json
configs/**/package-lock.json
great catch, not sure what generates them |
mcasimir
force-pushed
the
COMPASS-5268
branch
from
415e1f2 to
cec75ea
Compare
mcasimir
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds a
validateConnectionInfoErrors(connectionInfo: ConnectionInfo)which checks theconnectionInfofor common problems identified here asVALIDATION_ERRORChecklist
Motivation and Context
Open Questions
Dependents
Types of changes