feat(connect-form): Add SSL/TLS option radio box group #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Dec 21, 2021
addaleax
approved these changes
Dec 21, 2021
packages/connect-form/src/components/advanced-options-tabs/tls-ssl-tab/tls-ssl-tab.tsx
Show resolved
Hide resolved
addaleax
reviewed
Dec 21, 2021
packages/connect-form/src/components/advanced-options-tabs/tls-ssl-tab/tls-ssl-tab.tsx
Outdated
Show resolved
Hide resolved
addaleax
reviewed
Dec 21, 2021
| updatedConnectionString.searchParams.set('tls', 'false'); | ||
| } else if (tlsOption === TLS_OPTIONS.DEFAULT) { | ||
| updatedConnectionString.searchParams.delete('ssl'); | ||
| updatedConnectionString.searchParams.delete('tls'); |
There was a problem hiding this comment.
fyi, if #2651 is merged first it might be nice to update the core here to have similar changes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of COMPASS-5232 - decided to break it into a few PRs to hopefully make reviewing it a bit easier.
Here's how it looks:
tls-ssl-options.mp4
This PR has a bit of logic for removing
ssland using onlytls. Once we add more options for tls/ssl configuration we'll need to add a bit more to ensure when users change this setting we take their existing connection string into consideration (for example they havesslAllowInvalidCertificates=trueset and they change tls/ssl to on we can update it totlsAllowInvalidCertificates=true).In cases where we can't map the connection string ssl/tls into one of our three buckets we don't select any radio box.
We probably want to update the description for each mode. Open to ideas, I think we can also update them in a later pr if needed.