Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Jan 17, 2022

COMPASS-5232

Adds TLS options to the new connect form.
Updates the FileInput compass-components component to allow showing files on following lines and removing files (see video).

Some decisions we can discuss/improve/change:

env USE_NEW_CONNECT_FORM="true" npm start

Here's how it looks, and connecting to the devtools docker tls env:

options.1.mp4
editing.tls.options.mp4

Videos not totally up to date - the width changing glitch when switching tabs is fixed in a recent commit.

{label}
</span>
</div>
{optional && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: in the leafygreen UI, the optional text is always right next in the field and not label. should we align that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sgrinfy what do you think? Should we make this a follow up too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at the optional field for "Client Key Password", and the optional label is in the field like it should be. @mabaasit what should we align?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole thing came from the screenshot linked. the label on this input is getting cluttered with many options.

For LG input the label is on the right and within the input field. I suggested to align these two.

But now I feel like it will not look good either on file upload button.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I understand now. I would love to align these. Is this select file component only used in the connect form?

Screenshot 2022-01-18 at 14 41 27

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly. Its used in import to/export from collection modals as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that recent screenshot what it should be updated to @Sgrinfy ?
I'd like to merge this and update the styles in a follow up I'm thinking

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anemy No, let's leave it like it is currently implemented. This select file component it's used in other places too in Compass and I don't want to have slightly different styles. We can revaluate in future how to improve it.

@Anemy Anemy merged commit f706efe into main Jan 20, 2022
@Anemy Anemy deleted the COMPASS-5232-tls-tab-options branch January 20, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants