fix(saved-aggregations-queries): Just close the modal on delete cancel instead of deleting item anyway #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l instead of deleting item anyway
gribnoysup
commented
Feb 14, 2022
Comment on lines
-259
to
-261
| expect(() => { | ||
| screen.getByTestId(/delete item modal/i); | ||
| }, 'hides modal after deleting').to.throw; |
There was a problem hiding this comment.
This was throwing, but for a different reason, updated the logic here to wait for the modal to close and explicitly check that the item is not rendered anymore
mabaasit
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's what I get for not checking carefully changes that I committed on Friday. @mabaasit spotted that I was passing the same callback property both for deleting and cancelling the delete of an item in the list. This PR fixes it and adds tests for cancelling so that we don't mess it up anymore