Skip to content

Conversation

@addaleax
Copy link
Collaborator

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax addaleax requested a review from gagik February 27, 2025 14:58
Copy link
Contributor

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! assuming test-web-sandbox failures are unrelated.

@addaleax
Copy link
Collaborator Author

assuming test-web-sandbox failures are unrelated.

Unfortunately not 🙃 But the polyfill fix here seems to work locally (Slack thread)

@addaleax addaleax merged commit 5421da4 into main Mar 4, 2025
51 checks passed
@addaleax addaleax deleted the 9002-9006-dev branch March 4, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants